From 06b6bba31f6383c4a7499e07abb0c3a9d4b4d4a9 Mon Sep 17 00:00:00 2001 From: Christian Beutel <> Date: Fri, 10 Jan 2025 17:12:23 +0100 Subject: [PATCH] fixes list create bug new user --- .github/workflows/release.yaml | 9 ++++++--- CHANGELOG.md | 2 +- .../content/docs/getting-started/changelog.md | 2 +- web/src/routes/lists/edit/[id]/+page.svelte | 2 +- web/src/routes/profile/[id]/+layout.svelte | 19 +++++++++++++++---- 5 files changed, 24 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 68c22080..9161ca48 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -54,6 +54,8 @@ jobs: # 1. Checkout the repository - name: Checkout code uses: actions/checkout@v3 + with: + ref: ${{ github.ref }} - name: Setup Go uses: actions/setup-go@v4 @@ -108,7 +110,8 @@ jobs: # 1. Checkout the repository - name: Checkout code uses: actions/checkout@v3 - + with: + ref: ${{ github.ref }} # 2. Extract release notes from CHANGELOG.md - name: Extract release notes id: changelog @@ -123,7 +126,7 @@ jobs: in_section { print } ' CHANGELOG.md) echo 'changelog<> $GITHUB_OUTPUT - echo $CHANGELOG >> $GITHUB_OUTPUT + printf "%s\n" "$CHANGELOG" >> $GITHUB_OUTPUT echo 'EOF' >> $GITHUB_OUTPUT # 3. Create GitHub Release @@ -131,7 +134,7 @@ jobs: uses: actions/create-release@v1 with: tag_name: ${{ needs.versioning.outputs.version }} - release_name: "v${{ needs.versioning.outputs.version }}" + release_name: "${{ needs.versioning.outputs.version }}" body: ${{ steps.changelog.outputs.changelog }} draft: false prerelease: false diff --git a/CHANGELOG.md b/CHANGELOG.md index 605c86d5..b40d9abe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ - Improves server side rendering of certain components ## Translations -- Various additions across multiple languages (thanks to all contributers) +- Various additions across multiple languages (thanks to all contributors) ## Bug fixes - Fixes a bug that hid the map on some sites on mobile devices diff --git a/docs/src/content/docs/getting-started/changelog.md b/docs/src/content/docs/getting-started/changelog.md index 70fcad58..8108154d 100644 --- a/docs/src/content/docs/getting-started/changelog.md +++ b/docs/src/content/docs/getting-started/changelog.md @@ -9,7 +9,7 @@ description: What changed in the last patch? - Improves server side rendering of certain components ### Translations -- Various additions across multiple languages (thanks to all contributers) +- Various additions across multiple languages (thanks to all contributors) ### Bug fixes - Fixes a bug that hid the map on some sites on mobile devices diff --git a/web/src/routes/lists/edit/[id]/+page.svelte b/web/src/routes/lists/edit/[id]/+page.svelte index eeb8d815..7e8e797f 100644 --- a/web/src/routes/lists/edit/[id]/+page.svelte +++ b/web/src/routes/lists/edit/[id]/+page.svelte @@ -74,7 +74,7 @@ ...data.list, public: data.list.id ? data.list.public - : $page.data.settings?.privacy.lists === "public", + : $page.data.settings?.privacy?.lists === "public", }, extend: validator({ schema: ClientListCreateSchema, diff --git a/web/src/routes/profile/[id]/+layout.svelte b/web/src/routes/profile/[id]/+layout.svelte index 6b225742..0879d918 100644 --- a/web/src/routes/profile/[id]/+layout.svelte +++ b/web/src/routes/profile/[id]/+layout.svelte @@ -2,6 +2,7 @@ import { invalidateAll } from "$app/navigation"; import { page } from "$app/stores"; import Button from "$lib/components/base/button.svelte"; + import type { DropdownItem } from "$lib/components/base/dropdown.svelte"; import type { SelectItem } from "$lib/components/base/select.svelte"; import ProfileShareModal from "$lib/components/profile/profile_share_modal.svelte"; import { follows_create, follows_delete } from "$lib/stores/follow_store"; @@ -15,13 +16,22 @@ let followLoading: boolean = false; - const profileLinks: SelectItem[] = [ - { text: $_("profile"), value: `/profile/${$page.params.id}` }, + const profileLinks: DropdownItem[] = [ + { + text: $_("profile"), + value: `/profile/${$page.params.id}`, + icon: "user", + }, { text: $_("trail", { values: { n: 2 } }), value: `/profile/${$page.params.id}/trails`, + icon: "route", + }, + { + text: $_("statistics"), + value: `/profile/${$page.params.id}/stats`, + icon: "chart-pie", }, - { text: $_("statistics"), value: `/profile/${$page.params.id}/stats` }, ]; $: activeIndex = profileLinks.findIndex( @@ -113,7 +123,8 @@ {link.text}{link.text} {/each}